linux-kernel - Re: [RFC 0/4] sdhci: few patches for ENE 712 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E54DA38.1000408@qca.qualcomm.com>
Date:	Wed, 24 Aug 2011 14:02:16 +0300
From:	Kalle Valo <kvalo@....qualcomm.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	"Luis R. Rodriguez" <rodrigue@....qualcomm.com>,
	"cjb@...top.org" <cjb@...top.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"j@...fi" <j@...fi>
Subject: Re: [RFC 0/4] sdhci: few patches for ENE 712 support

Hi Wolfram,

going back to an old thread from March:

https://lkml.org/lkml/2011/3/18/433

Background:

Luis had problems with ath6kl (driver for ar6003 wifi chip using sdio)
and PCI ENE 712 SDIO extender and he had to use few ugly patches to get
it working. Later this year I inherited all this. I have been using the
hack patches until now but finally I started debugging this and I can
provide more information.

On 03/30/2011 10:47 AM, Wolfram Sang wrote:
>
>> I just tried this, it does not work, in fact my own my patches don't
work too,
>> only the original crap does though for some odd magical reason.
>>
>> Then again, what I tried was:
>>
>> insmod ./sdhci.ko debug_quirks=0x8028
>>
>> Was that what you wanted me to try?
>
> Yes. I assume this would have helped also (assuming that the original
> patchset was working), but looks like more investigation is needed.

I tried 0x8028 as well and it didn't help. But what I noticed was that
enabling SDHCI_QUIRK_FORCE_1_BIT_DATA with 0x00400038 makes it work.

Also I did some debugging on the hack patches and found out that the
hack patch below also makes ath6kl work with my ENE card. As suspected,
rest of the changes from the patches Luis sent were not needed.

http://www.valot.fi/kalle/tmp/sdhci-ene/sdhci-ene-idle-1bit-1.patch

So only needed change was to force 1 bit mode while the bus is idle. Any
ideas what would be the best way to fix this?

I'm currently using 3.1.0-rc2-wl+ from ath6kl.git which is based on
wireless-testing on an x86 32bit box. I can provide more information and
logs.

>> 03:0a.1 0805: 1524:0750
>
> Okay, so you have PCI_DEVICE_ID_ENE_CB714_SD and not
> PCI_DEVICE_ID_ENE_CB714_SD_2 (just in case they need to be dealt
> differently).

This is the device I have, it should be similar (if not the same) as Luis':

03:02.1 SD Host controller [0805]: ENE Technology Inc ENE PCI SmartMedia
/ xD Card Reader Controller [1524:0750] (prog-if 01)
        Subsystem: ENE Technology Inc ENE PCI SmartMedia / xD Card
Reader Controller [1524:0750]
        Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx-
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
        Interrupt: pin A routed to IRQ 19
        Region 0: Memory at febff800 (32-bit, non-prefetchable) [size=256]
        Capabilities: [80] Power Management version 2
                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
PME(D0+,D1+,D2+,D3hot+,D3cold-)
                Status: D0 PME-Enable- DSel=0 DScale=0 PME-
        Kernel driver in use: sdhci-pci
00: 24 15 50 07 02 00 10 02 00 01 05 08 08 40 80 00
10: 00 f8 bf fe 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 24 15 50 07
30: 00 00 00 00 80 00 00 00 00 00 00 00 05 01 20 48

>>> And does it make a difference if you use the SDIO-WLAN card or a
standard SD
>>> memory card?
>>
>> Um, I don't have physical access to the box, Naveen or Vipin would
have to
>> test this.
>
> Might be worth.

I tried with my 1GB SD card from my camera and oddly enough I didn't see
any new devices in /dev/sd*. But I don't know if I was missing some
important kernel config options, I have used this ENE card only with
ath6kl. I will retest this later.

Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/