linux-kernel - Re: [PATCHv2] ISP:BUILD:FIX: Move media_entity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201108241329.48147.laurent.pinchart@ideasonboard.com>
Date:	Wed, 24 Aug 2011 13:29:47 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	"Ravi, Deepthy" <deepthy.ravi@...com>
Cc:	"mchehab@...radead.org" <mchehab@...radead.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"Hiremath, Vaibhav" <hvaibhav@...com>
Subject: Re: [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and

Hi,

On Wednesday 24 August 2011 13:21:27 Ravi, Deepthy wrote:
> On Wed, Aug 24, 2011 at 4:47 PM, Laurent Pinchart wrote:
> > On Friday 19 August 2011 15:48:45 Deepthy Ravi wrote:
> >> From: Vaibhav Hiremath <hvaibhav@...com>
> >> 
> >> Fix the build break caused when CONFIG_MEDIA_CONTROLLER
> >> option is disabled and if any sensor driver has to be used
> >> between MC and non MC framework compatible devices.
> >> 
> >> For example,if tvp514x video decoder driver migrated to
> >> MC framework is being built without CONFIG_MEDIA_CONTROLLER
> >> option enabled, the following error messages will result.
> >> drivers/built-in.o: In function `tvp514x_remove':
> >> drivers/media/video/tvp514x.c:1285: undefined reference to
> >> `media_entity_cleanup'
> >> drivers/built-in.o: In function `tvp514x_probe':
> >> drivers/media/video/tvp514x.c:1237: undefined reference to
> >> `media_entity_init'
> > 
> > If the tvp514x is migrated to the MC framework, its Kconfig option should
> > depend on MEDIA_CONTROLLER.
>
> The same TVP514x driver is being used for both MC and non MC compatible
> devices, for example OMAP3 and AM35x. So if it is made dependent on MEDIA
> CONTROLLER, we cannot enable the driver for MC independent devices.

Then you should use conditional compilation in the tvp514x driver itself. Or 
better, port the AM35x driver to the MC API.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/