linux-kernel - Re: [PATCH] staging/olpc_dcon: Remove obsolete cleanup for clientdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110825130426.08ee06e5@endymion.delvare>
Date:	Thu, 25 Aug 2011 13:04:26 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	linux-i2c@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	Andres Salomon <dilinger@...ued.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Marek Belisko <marek.belisko@...n-nandra.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/olpc_dcon: Remove obsolete cleanup for
 clientdata

On Thu, 25 Aug 2011 12:53:30 +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
> 
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Cc: Andres Salomon <dilinger@...ued.net>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Marek Belisko <marek.belisko@...n-nandra.com>
> Cc: Jean Delvare <khali@...ux-fr.org>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index 750fe50..a235330 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -712,7 +712,6 @@ static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)
>   eirq:
>  	free_irq(DCON_IRQ, dcon);
>   einit:
> -	i2c_set_clientdata(client, NULL);
>  	kfree(dcon);
>  	return rc;
>  }
> @@ -721,8 +720,6 @@ static int dcon_remove(struct i2c_client *client)
>  {
>  	struct dcon_priv *dcon = i2c_get_clientdata(client);
>  
> -	i2c_set_clientdata(client, NULL);
> -
>  	fb_unregister_client(&dcon->fbevent_nb);
>  	unregister_reboot_notifier(&dcon->reboot_nb);
>  	atomic_notifier_chain_unregister(&panic_notifier_list, &dcon_panic_nb);

Acked-by: Jean Delvare <khali@...ux-fr.org>

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/