linux-kernel - Re: [PATCH] perf_event: fix slow and broken cgroup context switch code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1314282148.27911.13.camel@twins>
Date:	Thu, 25 Aug 2011 16:22:28 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, ming.m.lin@...el.com
Subject: Re: [PATCH] perf_event: fix slow and broken cgroup context switch
 code

On Thu, 2011-08-25 at 15:58 +0200, Stephane Eranian wrote:
> +static inline void perf_event_task_sched_in(struct task_struct *prev,
> +                                           struct task_struct *task)
>  {
>         if (static_branch(&perf_sched_events))
> +               __perf_event_task_sched_in(prev, task);
>  }
>  
> +static inline void perf_event_task_sched_out(struct task_struct *prev,
> +                                            struct task_struct *next)
>  {
>         perf_sw_event(PERF_COUNT_SW_CONTEXT_SWITCHES, 1, NULL, 0);
>  
> +       if (static_branch(&perf_sched_events))
> +               __perf_event_task_sched_out(prev, next);
>  }

BTW, Ingo, is there any particular reason we have these two calls and
not a single perf_event_task_switch() call?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/