linux-kernel - Re: [PATCH]arm: nwfpe: '&pointer[0]' to 'pointer' fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110825191501.GA4488@n2100.arm.linux.org.uk>
Date:	Thu, 25 Aug 2011 20:15:01 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	"Maxin B. John" <maxin.john@...il.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]arm: nwfpe: '&pointer[0]' to 'pointer' fix

On Thu, Aug 25, 2011 at 10:11:43PM +0300, Maxin B. John wrote:
> '&pointer[0]' to 'pointer' fix in arch/arm/nwfpe/fpa11_cpdt.c 

Your reason being?

>  #ifdef __ARMEB__
> -	get_user(p[0], &pMem[0]);	/* sign & exponent */
> +	get_user(p[0], pMem);	/* sign & exponent */
>  	get_user(p[1], &pMem[1]);

You may notice the original code has some consistency.  Your replacement
is less consistent.  If you wish to make this change, it should change to:

	get_user(p[0], pMem + 0);
	get_user(p[1], pMem + 1);

to maintain consistency.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/