linux-kernel - Re: [PATCH 1/5 v5] arm: omap: usb: ehci and ohci hwmod structures for omap4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP05o4L1WtuLUA_Bz-W-ZrdQcBeyu_h_ahzQ5zZAANYTP3h3Tw@mail.gmail.com>
Date:	Thu, 25 Aug 2011 12:12:45 +0530
From:	"Munegowda, Keshava" <keshava_mgowda@...com>
To:	Roger Quadros <rogerq@...com>
Cc:	b-cousson@...com, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	balbi@...com, gadiyar@...com, sameo@...ux.intel.com,
	parthab@...ia.ti.com, tony@...mide.com, khilman@...com,
	paul@...an.com, johnstul@...ibm.com, vishwanath.bs@...com,
	tom.leiming@...il.com, toddpoynor@...gle.com
Subject: Re: [PATCH 1/5 v5] arm: omap: usb: ehci and ohci hwmod structures for omap4

On Wed, Aug 24, 2011 at 4:30 PM, Munegowda, Keshava
<keshava_mgowda@...com> wrote:
> On Wed, Aug 24, 2011 at 12:27 PM, Roger Quadros <rogerq@...com> wrote:
>> Hi,
>>
>> On 08/17/2011 02:43 PM, Keshava Munegowda wrote:
>>> From: Benoit Cousson <b-cousson@...com>
>>>
>>> Following 4 hwmod strcuture are added:
>>> UHH hwmod of usbhs with uhh base address and functional clock,
>>> EHCI hwmod with irq and base address,
>>> OHCI hwmod with irq and base address,
>>> TLL hwmod of usbhs with the TLL base address and irq.
>>>
>>> Signed-off-by: Benoit Cousson <b-cousson@...com>
>>> Signed-off-by: Keshava Munegowda <keshava_mgowda@...com>
>>> ---
>>>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  244 ++++++++++++++++++++++++++++
>>>  1 files changed, 244 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>>> index 6201422..d8f08fa 100644
>>> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>>> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>>> @@ -68,6 +68,10 @@ static struct omap_hwmod omap44xx_mmc2_hwmod;
>>>  static struct omap_hwmod omap44xx_mpu_hwmod;
>>>  static struct omap_hwmod omap44xx_mpu_private_hwmod;
>>>  static struct omap_hwmod omap44xx_usb_otg_hs_hwmod;
>>> +static struct omap_hwmod omap44xx_usb_host_hs_hwmod;
>>> +static struct omap_hwmod omap44xx_usbhs_ohci_hwmod;
>>> +static struct omap_hwmod omap44xx_usbhs_ehci_hwmod;
>>> +static struct omap_hwmod omap44xx_usb_tll_hs_hwmod;
>>>
>>>  /*
>>>   * Interconnects omap_hwmod structures
>>> @@ -5336,6 +5340,242 @@ static struct omap_hwmod omap44xx_wd_timer3_hwmod = {
>>>       .omap_chip      = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
>>>  };
>>>
>>> +/*
>>> + * 'usb_host_hs' class
>>> + * high-speed multi-port usb host controller
>>> + */
>>> +static struct omap_hwmod_ocp_if omap44xx_usb_host_hs__l3_main_2 = {
>>> +     .master         = &omap44xx_usb_host_hs_hwmod,
>>> +     .slave          = &omap44xx_l3_main_2_hwmod,
>>> +     .clk            = "l3_div_ck",
>>> +     .user           = OCP_USER_MPU | OCP_USER_SDMA,
>>> +};
>>> +
>>> +static struct omap_hwmod_class_sysconfig omap44xx_usb_host_hs_sysc = {
>>> +     .rev_offs       = 0x0000,
>>> +     .sysc_offs      = 0x0010,
>>> +     .syss_offs      = 0x0014,
>>> +     .sysc_flags     = (SYSC_HAS_MIDLEMODE | SYSC_HAS_SIDLEMODE),
>>
>> what about SYSC_HAS_SOFTRESET?
>
> Yes, I will add this for omap3 , for omap4 this flag is causing
> enumeration issue.
> for now , I will not add this for 4430.

Roger,
I can not add this SYSC_HAS_SOFTRESET for omap3 too;
its blocks the port status change interrupts after the global suspend/resume;
so v7 I add this for omap3, I will remove this and send it as v8 now.

regards
keshava


>
>
>>
>>> +     .idlemodes      = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
>>
>> Did you intentionally miss out SIDLE_SMART_WKUP ?
>
> it is not there for omap3 but I will add this for omap4.
>
>
>>
>>> +                        MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART |
>>> +                             MSTANDBY_SMART_WKUP),
>>> +     .sysc_fields    = &omap_hwmod_sysc_type2,
>>> +};
>>> +
>>
>> ...
>> <snip>
>> ...
>>
>>> +
>>> +/*
>>> + * 'usb_tll_hs' class
>>> + * usb_tll_hs module is the adapter on the usb_host_hs ports
>>> + */
>>> +static struct omap_hwmod_class_sysconfig omap44xx_usb_tll_hs_sysc = {
>>> +     .rev_offs       = 0x0000,
>>> +     .sysc_offs      = 0x0010,
>>> +     .syss_offs      = 0x0014,
>>> +     .sysc_flags     = (SYSC_HAS_AUTOIDLE | SYSC_HAS_SIDLEMODE),
>>
>> what about SYSC_HAS_SOFTRESET, SYSC_HAS_ENAWAKEUP and
>> SYSC_HAS_CLOCKACTIVITY?
>
> yes, I will add these flags ;
>
>
> I will send the v7 soon.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/