linux-kernel - Re: [PATCH] staging: brcmfmac: Consolidate debugging macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6ryWtZG9obyj0w=d5jrF-y1pYNmanhkze2F429kHCLCi=A@mail.gmail.com>
Date:	Fri, 26 Aug 2011 10:55:17 +0200
From:	Rafał Miłecki <zajec5@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Henry Ptasinski <henryp@...adcom.com>,
	linux-kernel@...r.kernel.org, Brett Rudley <brudley@...adcom.com>,
	Arend Van Spriel <arend@...adcom.com>,
	Roland Vossen <rvossen@...adcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	devel@...uxdriverproject.org, Greg KH <gregkh@...e.de>,
	Kan Yan <kanyan@...adcom.com>, linux-wireless@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: brcmfmac: Consolidate debugging macros

2011/8/25 Joe Perches <joe@...ches.com>:
> Convert multiple BRCMF_<debug_level> macros to a single
> brcmf_dbg(level, fmt, ...) macro.

I'm not sure if that "_dbg" suffix is a really good choice. You use
"_dbg" for all the kinds of messages, while "DEBUG" is already one
kind of messages. We have also other types like EMERG, ALERT, CRIT,
ERR, WARNING, NOTICE, INFO and DEBUG.

You choice makes it messy according to me.

Wouldn't something like brcmf_print be much better choice?

I really don't like such a mixing dbg&DEBUG, dbd&ERR, etc.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/