linux-kernel - Re: [PATCH 1/4] dynamic_debug: consolidate repetitive struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO+b5-qfVRjQWNbdzK-GdU+GJT45LuifNSAYvn8bzpw+d=8O4A@mail.gmail.com>
Date:	Fri, 26 Aug 2011 12:46:51 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Jason Baron <jbaron@...hat.com>
Cc:	gregkh@...e.de, joe@...ches.com, jim.cromie@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dynamic_debug: consolidate repetitive struct _ddebug
 descriptor definitions

On Thu, Aug 25, 2011 at 7:34 PM, Jason Baron <jbaron@...hat.com> wrote:
>
> +#define DECLARE_DYNAMIC_DEBUG_METADATA(name, fmt)              \
> +       static struct _ddebug __used __aligned(8)               \
> +       __attribute__((section("__verbose"))) name = {          \
> +               .modname = KBUILD_MODNAME,                      \
> +               .function = __func__,                           \
> +               .filename = __FILE__,                           \
> +               .format = fmt,                                  \
> +               .lineno = __LINE__,                             \
> +               .flags =  _DPRINTK_FLAGS_DEFAULT,               \
> +               .enabled = false,                               \
> +       }

A minor remark: macro arguments are usually surrounded by parentheses
in a macro definition. That's not the case for "fmt" in the above.

Bart.