linux-kernel - Re: [PATCH 1/2] mm: convert k{un}map_atomic(p, KM_type) to k{un}map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Aug 2011 12:42:39 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Lin Ming <ming.m.lin@...el.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, x86@...nel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/2] mm: convert k{un}map_atomic(p, KM_type) to
 k{un}map_atomic(p)

On Fri, 26 Aug 2011 10:58:16 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> On Fri, 2011-08-26 at 16:17 +0800, Lin Ming wrote:
> > 
> > The KM_type parameter for kmap_atomic/kunmap_atomic is not used anymore
> > since commit 3e4d3af(mm: stack based kmap_atomic()).
> > 
> > So convert k{un}map_atomic(p, KM_type) to k{un}map_atomic(p).
> > Most conversion are done by below commands. Some are done by hand.
> > 
> > find . -type f | xargs sed -i 's/\(kmap_atomic(.*\),\ .*)/\1)/'
> > find . -type f | xargs sed -i 's/\(kunmap_atomic(.*\),\ .*)/\1)/'
> > 
> > Build and tested on 32/64bit x86 kernel(allyesconfig) with 3G memory.
> > 
> > ARM, MIPS, PowerPc and Sparc are build tested only with
> > CONFIG_HIGHMEM=y and CONFIG_HIGHMEM=n.
> > I don't have cross-compiler for other arches. 
> 
> yet-another-massive patch.. (you're the third or fourth to do so) if
> Andrew wants to take this one I won't mind, however previously he didn't
> want flag day patches..

I'm OK with cleaning all these up, but I suggest that we leave the
back-compatibility macros in place for a while, to make sure that
various stragglers get converted.  Extra marks will be awarded for
working out how to make unconverted code generate a compile warning ;)

Perhaps you could dust off your old patch and we'll bring it up to date?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/