linux-kernel - Re: [PATCH 0/4] dynamic debug: cleanups + compile fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110826221845.GA18858@suse.de>
Date:	Fri, 26 Aug 2011 15:18:45 -0700
From:	Greg KH <gregkh@...e.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Jason Baron <jbaron@...hat.com>, Greg KH <greg@...ah.com>,
	jim.cromie@...il.com, bvanassche@....org, rdunlap@...otime.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] dynamic debug: cleanups + compile fix

On Fri, Aug 26, 2011 at 03:14:41PM -0700, Joe Perches wrote:
> On Fri, 2011-08-26 at 12:04 -0700, Greg KH wrote:
> > On Fri, Aug 26, 2011 at 02:47:42PM -0400, Jason Baron wrote:
> > > On Fri, Aug 26, 2011 at 11:29:00AM -0700, Greg KH wrote:
> > > > On Thu, Aug 25, 2011 at 01:34:06PM -0400, Jason Baron wrote:
> > > > > Hi,
> > > > > 
> > > > > This is a re-post of the last 3 patches, as requested by Greg:
> > > > > https://lkml.org/lkml/2011/8/11/378
> > > > > 
> > > > > I've also added a compile fix that Randy Dunlap found in the -next tree.
> > > > 
> > > > Care to redo this based on the comments received so far?
> > > > 
> > > 
> > > Hi,
> > > 
> > > I re-posted 3/4 based on the comments already. The comment on patch #1
> > > regarding adding macro parenthesis, I don't believe makes any functional
> > > change...do you still need a re-post the series?
> > 
> > Yes, please fix patch #1 adding the needed parenthesis and resend the
> > whole series.
> 
> The parentheses aren't need.
> 
> A macro like
> #define foo(a, b) a = b
> 
> that only uses each argument once without doing arithmetic
> gains nothing from parentheses.
> 
> Just like
> #define true 1
> gains nothing from parenthesis either.

I don't think that is the case here, right?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/