linux-kernel - Re: [PATCH 2/3] broadcast-tick: Move oneshot broadcast mask to per cpu variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 27 Aug 2011 00:48:42 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	tim.c.chen@...ux.intel.com, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/3] broadcast-tick: Move oneshot broadcast mask to per
 cpu variables

Le vendredi 26 août 2011 à 15:32 -0700, Andi Kleen a écrit :
> From: Andi Kleen <ak@...ux.intel.com>
> 
> Avoid a global cache line hotspot in the oneshot cpu mask. Maintain
> this information in per cpu variables instead.
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---

>  
> -/* FIXME: use cpumask_var_t. */
> -static DECLARE_BITMAP(tick_broadcast_oneshot_mask, NR_CPUS);
> +struct broadcast_cpu_state {
> +	int need_oneshot;
> +} ____cacheline_aligned;
> +static DEFINE_PER_CPU(struct broadcast_cpu_state, state);

static DEFINE_PER_CPU_ALIGNED(...)

It avoids adding an alignment requirement on .data..percpu



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/