linux-kernel - [Power-supply]: Error handling in max17042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <12D0C12AF19E15409D57F22566E88EF5097576EBFB@bgsmsx501.gar.corp.intel.com>
Date:	Fri, 26 Aug 2011 11:16:53 +0530
From:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"cbouatmailru@...il.com" <cbouatmailru@...il.com>,
	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
Subject: [Power-supply]: Error handling in max17042_battery.c

Hi All,

I am working on the I2C based max17042 fuel gauge driver
Which is drivers/power/max17042_battery.c

In max17042_get_property(...), the values returned by
Max17042_read_reg are directly assigned to the variables,
even if the read results in an error. Shouldn't we check
for the 'correctness' of the returned values and then
assign them ? Can I submit a patch to change this ?

Or Is this done intentionally ?

Thanks,
Ram



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/