linux-kernel - Re: [PATCH] iommu: Remove stub functions for !CONFIG_IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK=WgbaiNxo_226Zp9BZpgUjYFajnvgPPCjCOYP2Tj4pkWTwVA@mail.gmail.com>
Date:	Sat, 27 Aug 2011 14:56:39 +0300
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	David Brown <davidb@...eaurora.org>,
	Stepan Moskovchenko <stepanm@...eaurora.org>
Subject: Re: [PATCH] iommu: Remove stub functions for !CONFIG_IOMMU_API

On Fri, Aug 26, 2011 at 4:20 PM, Joerg Roedel <joerg.roedel@....com> wrote:
> Remove most of the stub functions because they are only
> allowed to use when CONFIG_IOMMU_API is set anyway. This
> will catch missing 'select' entries in kconfig at compile
> time already.

I'm not sure we want this; think about a generic framework/driver that
uses the IOMMU API only if the underlying hardware has an IOMMU and
otherwise will skip calling the IOMMU API altogether (e.g. this is
where remoteproc is headed).

With this patch, such generic code will have to "select IOMMU_API"
unconditionally, or it won't build when the hardware doesn't have an
IOMMU (e.g. the DSP in at least several of the DaVinci SoC isn't
behind an IOMMU). But doing so is a bit wasteful if there's no IOMMU
hardware...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/