linux-kernel - Re: [PATCH] driver/misc/fsa9480.c fix potential null-pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110826171849.4f488908.akpm@linux-foundation.org>
Date:	Fri, 26 Aug 2011 17:18:49 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	jhbird.choi@...sung.com
Cc:	linux-kernel@...r.kernel.org, Donggeun Kim <dg77.kim@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH] driver/misc/fsa9480.c fix potential null-pointer
 dereference

On Tue, 26 Jul 2011 17:19:35 +0900
jhbird.choi@...sung.com wrote:

> From: Jonghwan Choi <jhbird.choi@...sung.com>
> 
> Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com>
> ---
>  drivers/misc/fsa9480.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/fsa9480.c b/drivers/misc/fsa9480.c
> index 5325a7e..0bd1e5b 100644
> --- a/drivers/misc/fsa9480.c
> +++ b/drivers/misc/fsa9480.c
> @@ -400,7 +400,8 @@ static int fsa9480_irq_init(struct fsa9480_usbsw *usbsw)
>  			return ret;
>  		}
>  
> -		device_init_wakeup(&client->dev, pdata->wakeup);
> +		if (pdata)
> +			device_init_wakeup(&client->dev, pdata->wakeup);
>  	}
>  
>  	return 0;

So i2c_client.dev.platform_data was NULL.  Is this an allowed state? 
What would cause this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/