[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1314514612.6852.11.camel@Joe-Laptop>
Date: Sat, 27 Aug 2011 23:56:52 -0700
From: Joe Perches <joe@...ches.com>
To: "K. Y. Srinivasan" <kys@...rosoft.com>
Cc: gregkh@...e.de, linux-kernel@...r.kernel.org,
devel@...uxdriverproject.org, virtualization@...ts.osdl.org,
Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in
connection.c
On Sat, 2011-08-27 at 11:31 -0700, K. Y. Srinivasan wrote:
> Fix checkpatch warnings in connection.c.
[]
> diff --git a/drivers/staging/hv/connection.c b/drivers/staging/hv/connection.c
[]
> @@ -220,11 +220,11 @@ static void process_chn_event(u32 relid)
> channel = relid2channel(relid);
>
> spin_lock_irqsave(&channel->inbound_lock, flags);
> - if (channel && (channel->onchannel_callback != NULL)) {
> + if (channel && (channel->onchannel_callback != NULL))
Useless test for channel or bad placement for spin_lock.
channel has already been dereferenced by the spin_lock.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists