linux-kernel - Re: [PATCH] sound: usb: mixer: increase control transfer timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110829122320.GX13925@legolas.emea.dhcp.ti.com>
Date:	Mon, 29 Aug 2011 15:23:21 +0300
From:	Felipe Balbi <balbi@...com>
To:	Clemens Ladisch <clemens@...isch.de>
Cc:	Felipe Balbi <balbi@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	Linux USB Mailing List <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] sound: usb: mixer: increase control transfer timeout

Hi,

On Mon, Aug 29, 2011 at 01:58:31PM +0200, Clemens Ladisch wrote:
> Felipe Balbi wrote:
> > 100ms might not be enough for slower devices. Increasing
> > timeout to 1000ms doesn't seem like overkill.
> > 
> > --- a/sound/usb/mixer.c
> > +++ b/sound/usb/mixer.c
> > @@ -296,7 +296,7 @@ static int get_ctl_value_v1(struct usb_mixer_elem_info *cval, int request, int v
> >  		if (snd_usb_ctl_msg(chip->dev, usb_rcvctrlpipe(chip->dev, 0), request,
> >  				    USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN,
> >  				    validx, snd_usb_ctrl_intf(chip) | (cval->id << 8),
> > -				    buf, val_len, 100) >= val_len) {
> > +				    buf, val_len, 1000) >= val_len) {
> 
> If the timeout for reading values needs to be increased, writing (in
> snd_usb_mixer_set_ctl_value) probably needs some attention too.

Ok, I'll increase all 100ms delays to 1000. Is that ok ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)