[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110829170143.GB9748@somewhere.redhat.com>
Date: Mon, 29 Aug 2011 19:01:46 +0200
From: Frederic Weisbecker <fweisbec@...il.com>
To: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Anton Blanchard <anton@....ibm.com>,
Avi Kivity <avi@...hat.com>, Ingo Molnar <mingo@...e.hu>,
Lai Jiangshan <laijs@...fujitsu.com>,
"Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
Stephen Hemminger <shemminger@...tta.com>,
Thomas Gleixner <tglx@...utronix.de>,
Tim Pepper <lnxninja@...ux.vnet.ibm.com>,
Paul Menage <paul@...lmenage.org>
Subject: Re: [PATCH 04/32] nohz: Separate idle sleeping time accounting from
nohz switching
On Mon, Aug 29, 2011 at 04:23:29PM +0200, Peter Zijlstra wrote:
> On Mon, 2011-08-15 at 17:52 +0200, Frederic Weisbecker wrote:
> > +extern void tick_nohz_exit_idle(void);
> > +extern void tick_nohz_irq_exit(void);
>
> For consistencies sake, pick either tick_nohz_exit_*() or
> tick_nohz_*_exit() but don't go mix and match (I prefer the former).
Agreed, I will.
> Also, there isn't a matching irq_enter() callback..
Yeah, probably tick_check_nohz() should be renamed accordingly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists