linux-kernel - [PATCH 3/6] staging: et131x: Remove unused xcvr_id in struct ce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Aug 2011 18:42:38 +0100
From:	Mark Einon <mark.einon@...il.com>
To:	gregkh@...e.de
Cc:	greg@...ah.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, o.hartmann@...ovital.com,
	Mark Einon <mark.einon@...il.com>
Subject: [PATCH 3/6] staging: et131x: Remove unused xcvr_id in struct ce_stats

xcvr_id holds the phy ID which is stored but never used in the driver.

Signed-off-by: Mark Einon <mark.einon@...il.com>
---
 drivers/staging/et131x/et1310_phy.c     |    4 ----
 drivers/staging/et131x/et131x_adapter.h |    1 -
 2 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/et131x/et1310_phy.c b/drivers/staging/et131x/et1310_phy.c
index c845c27..21e0704 100644
--- a/drivers/staging/et131x/et1310_phy.c
+++ b/drivers/staging/et131x/et1310_phy.c
@@ -242,7 +242,6 @@ int et131x_xcvr_find(struct et131x_adapter *adapter)
 	u8 xcvr_addr;
 	u16 idr1;
 	u16 idr2;
-	u32 xcvr_id;
 
 	/* We need to get xcvr id and address we just get the first one */
 	for (xcvr_addr = 0; xcvr_addr < 32; xcvr_addr++) {
@@ -254,10 +253,7 @@ int et131x_xcvr_find(struct et131x_adapter *adapter)
 			     (u8) offsetof(struct mi_regs, idr2),
 			     &idr2);
 
-		xcvr_id = (u32) ((idr1 << 16) | idr2);
-
 		if (idr1 != 0 && idr1 != 0xffff) {
-			adapter->stats.xcvr_id = xcvr_id;
 			adapter->stats.xcvr_addr = xcvr_addr;
 			return 0;
 		}
diff --git a/drivers/staging/et131x/et131x_adapter.h b/drivers/staging/et131x/et131x_adapter.h
index 762e07c..b03460b 100644
--- a/drivers/staging/et131x/et131x_adapter.h
+++ b/drivers/staging/et131x/et131x_adapter.h
@@ -115,7 +115,6 @@ struct ce_stats {
 
 	/* Transceiver state informations. */
 	u8		xcvr_addr;
-	u32		xcvr_id;
 
 	/* Tx Statistics. */
 	u32		tx_underflows;
-- 
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/