linux-kernel - Re: linux-next: build warning after merge of the ptrace tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110829182018.GA14729@redhat.com>
Date:	Mon, 29 Aug 2011 20:20:18 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Tejun Heo <tj@...nel.org>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, Matt Fleming <matt.fleming@...el.com>
Subject: Re: linux-next: build warning after merge of the ptrace tree

Hi Stephen,

On 08/29, Stephen Rothwell wrote:
>
> After merging the ptrace tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/autofs4/waitq.c: In function 'autofs4_wait':
> fs/autofs4/waitq.c:462:17: warning: unused variable 'irqflags'
>
> Introduced by commit 33ee1d9bc213 ("autofs4: Use set_current_blocked()").

Argh. Thanks again.

I've committed the trivial fix.

Oleg.

commit 2efd0a8f5a5e981022faaec780ee00c05eeee8aa
Author: Oleg Nesterov <oleg@...hat.com>
Date:   Mon Aug 29 20:17:24 2011 +0200

    autofs4_wait: remove the unused irqflags variable
    
    irqflags is not used since 33ee1d9bc213, remove it.
    
    Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
    Signed-off-by: Oleg Nesterov <oleg@...hat.com>

diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 58ba49a..09fb503 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -459,7 +459,6 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry,
 	if (wq->name.name) {
 		/* Block all but "shutdown" signals while waiting */
 		sigset_t oldset, blocked;
-		unsigned long irqflags;
 
 		oldset = current->blocked;
 		siginitsetinv(&blocked, SHUTDOWN_SIGS & ~oldset.sig[0]);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/