linux-kernel - Re: RE: [Power-supply]: Error handling in max17042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <7455484.255921314597492899.JavaMail.weblogic@epml19>
Date:	Mon, 29 Aug 2011 05:58:13 +0000 (GMT)
From:	함명주 <myungjoo.ham@...sung.com>
To:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"cbouatmailru@...il.com" <cbouatmailru@...il.com>
Subject: Re: RE: [Power-supply]: Error handling in max17042_battery.c

I guess your spam filter filtered out my reply..?

The reply posted 3 days ago: https://lkml.org/lkml/2011/8/26/32

In short, please go ahead.


Cheers
MyungJoo

------- Original Message -------
Sender : Pallala, Ramakrishna<ramakrishna.pallala@...el.com>
Date : 2011-08-29 14:30 (GMT+09:00)
Title : RE: [Power-supply]: Error handling in max17042_battery.c

> Hi All,
> 
> I am working on the I2C based max17042 fuel gauge driver
> Which is drivers/power/max17042_battery.c
> 
> In max17042_get_property(...), the values returned by
> Max17042_read_reg are directly assigned to the variables,
> even if the read results in an error. Shouldn't we check
> for the 'correctness' of the returned values and then
> assign them ? Can I submit a patch to change this ?
> 
> Or Is this done intentionally ?

Any inputs on this?

Thanks,
Ram



 MyungJoo Ham (함명주)
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033