linux-kernel - Re: [PATCH] thp: tail page refcounting fix #4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110829233001.GM4051@redhat.com>
Date:	Tue, 30 Aug 2011 01:30:01 +0200
From:	Andrea Arcangeli <aarcange@...hat.com>
To:	Michel Lespinasse <walken@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Hugh Dickins <hughd@...gle.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Johannes Weiner <jweiner@...hat.com>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mgorman@...e.de>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Shaohua Li <shaohua.li@...el.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH] thp: tail page refcounting fix #4

On Mon, Aug 29, 2011 at 03:40:07PM -0700, Michel Lespinasse wrote:
> Looks great.

Thanks!

> I think some page_mapcount call sites would be easier to read if you
> took on my tail_page_count() suggestion (so we can casually see it's a
> refcount rather than mapcount). But you don't have to do it if you
> don't think it helps. I'm happy enough with the code already :)

I initially tried to do it but I wanted it in internal.h (it's really
an internal thing not mean for any driver whatsoever) but then the
gup.c files wouldn't see it, so I wasn't sure how to proceed and I
dropped it. It's still possible to do it later...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/