linux-kernel - Re: [RFC PATCH] x86: perf: Clean up perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1314704115.2799.12.camel@twins>
Date:	Tue, 30 Aug 2011 13:35:15 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Kevin Winchester <kjwinchester@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] x86: perf: Clean up perf_event cpu code

On Tue, 2011-08-30 at 08:21 -0300, Kevin Winchester wrote:
> 
> This is the first time I've attempted a patch this large.  Should I break it up
> into smaller pieces?  

Only if it makes sens, intermediate stages should still compile. I could
imagine you creating the header file and moving stuff in there one thing
at a time while keeping the whole thing compiling. Eventually resulting
in the state where the #include hackery is superfluous and can be
removed.

If its worth spending a lot of time making that happen is another thing.

> Or does that requirement not really apply since it's just
> a cleanup patch?

Cleanup isn't the criteria. The individual steps have to make sense.

Take for instance the uprobe patch set as an example of how not to split
up things. The individual patches don't really stand on their own and
you're constantly forced to switch back and forth while reviewing, a
total pain.

> Also, it is based on Linus' tree, should I base it on tip instead?

Yes please. I don't think they differ a lot but tip is where it'll end
up being applied to, so it helps if it does indeed apply ;-)

Otherwise looks good, thanks a bunch!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/