linux-kernel - Re: [PATCH] fix the outdated comment in ext2_nfs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110830153944.GF16202@quack.suse.cz>
Date:	Tue, 30 Aug 2011 17:39:44 +0200
From:	Jan Kara <jack@...e.cz>
To:	Li Haifeng <omycle@...il.com>
Cc:	jack@...e.cz, linux-kernel@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()

On Tue 30-08-11 20:11:28, Li Haifeng wrote:
> I am sorry, the last patch "fix the outdated comment in
> ext2_nfs_get_inode()" has some " whitespace errors detected". So
> correct it and remake it.
> 
> I will be more careful later.
  Hmm, your patch still has mangled whitespaces and wrapped long lines.
Please make sure your mailer doesn't do it or use git send-email to send
patches. Also the subject line misses "ext2:" in the beginning (after
[PATCH]). Finally, I've further changed the text in the comment because
"And" does not really make sense in that context to me. The patch I now
carry in my tree is below.

								Honza

>From 8e871fa6a2db8ec615614e547d95de21f9045a52 Mon Sep 17 00:00:00 2001
From: Li Haifeng <omycle@...il.com>
Date: Tue, 30 Aug 2011 17:32:50 +0200
Subject: [PATCH] ext2: fix the outdated comment in ext2_nfs_get_inode()

Signed-off-by: Li Haifeng <omycle@...il.com>
Signed-off-by: Jan Kara <jack@...e.cz>
---
 fs/ext2/super.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 174782f..adf3cde 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -327,10 +327,10 @@ static struct inode *ext2_nfs_get_inode(struct super_block *sb,
 	if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
 		return ERR_PTR(-ESTALE);
 
-	/* iget isn't really right if the inode is currently unallocated!!
-	 * ext2_read_inode currently does appropriate checks, but
-	 * it might be "neater" to call ext2_get_inode first and check
-	 * if the inode is valid.....
+	/*
+	 * ext2_iget isn't quite right if the inode is currently unallocated!
+	 * However ext2_iget currently does appropriate checks to handle stale
+	 * inodes so everything is OK.
 	 */
 	inode = ext2_iget(sb, ino);
 	if (IS_ERR(inode))
-- 
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/