linux-kernel - Re: [PATCH v2] kbuild: prevent make from deleting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Aug 2011 20:27:23 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	mmarek@...e.cz
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Kbuild Mailing List <linux-kbuild@...r.kernel.org>,
	Peter Foley <pefoley2@...izon.net>
Subject: Re: [PATCH v2] kbuild: prevent make from deleting _shipped files

Hi,

On Sun, Jul 31, 2011 at 3:03 PM, Arnaud Lacombe <lacombar@...il.com> wrote:
> Hi,
>
> On Sun, Jul 31, 2011 at 2:45 PM, Peter Foley <pefoley2@...izon.net> wrote:
>> commit 7373f4f (kbuild: add implicit rules for parser generation)
>> created a implicit rule chain (%.c: %.c_shipped: %.y).
>> Make considers the _shipped files to be intermediate files which
>> causes them to be deleted if they didn't exist before make was run.
>> Mark the _shipped files PRECIOUS to prevent make from deleting them.
>>
>> Signed-off-by: Peter Foley <pefoley2@...izon.net>
>
> Acked-by: Arnaud Lacombe <lacombar@...il.com>
>
ping, Michal ?

 - Arnaud

>  - Arnaud
>
>> ---
>>
>> V2: update changelog to specify files are only deleted when they did not
>> already exist
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index aeea84a..5d986d9 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -167,6 +167,7 @@ ifdef REGENERATE_PARSERS
>>  quiet_cmd_gperf = GPERF $@
>>       cmd_gperf = gperf -t --output-file $@ -a -C -E -g -k 1,3,$$ -p -t $<
>>
>> +.PRECIOUS: $(src)/%.hash.c_shipped
>>  $(src)/%.hash.c_shipped: $(src)/%.gperf
>>        $(call cmd,gperf)
>>
>> @@ -177,6 +178,7 @@ LEX_PREFIX = $(if $(LEX_PREFIX_${baseprereq}),$(LEX_PREFIX_${baseprereq}),yy)
>>  quiet_cmd_flex = LEX     $@
>>       cmd_flex = flex -o$@ -L -P $(LEX_PREFIX) $<
>>
>> +.PRECIOUS: $(src)/%.lex.c_shipped
>>  $(src)/%.lex.c_shipped: $(src)/%.l
>>        $(call cmd,flex)
>>
>> @@ -187,12 +189,14 @@ YACC_PREFIX = $(if $(YACC_PREFIX_${baseprereq}),$(YACC_PREFIX_${baseprereq}),yy)
>>  quiet_cmd_bison = YACC    $@
>>       cmd_bison = bison -o$@ -t -l -p $(YACC_PREFIX) $<
>>
>> +.PRECIOUS: $(src)/%.tab.c_shipped
>>  $(src)/%.tab.c_shipped: $(src)/%.y
>>        $(call cmd,bison)
>>
>>  quiet_cmd_bison_h = YACC    $@
>>       cmd_bison_h = bison -o/dev/null --defines=$@ -t -l -p $(YACC_PREFIX) $<
>>
>> +.PRECIOUS: $(src)/%.tab.h_shipped
>>  $(src)/%.tab.h_shipped: $(src)/%.y
>>        $(call cmd,bison_h)
>>
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/