linux-kernel - Re: [patch v2 21/35] Hexagon: Add SMP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110830205020.GB9938@codeaurora.org>
Date:	Tue, 30 Aug 2011 15:50:20 -0500
From:	Richard Kuo <rkuo@...eaurora.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, linux-hexagon@...r.kernel.org
Subject: Re: [patch v2 21/35] Hexagon: Add SMP support

On Tue, Aug 30, 2011 at 12:30:36PM -0700, Joe Perches wrote:
> > +		unsigned long msg = msg = ffz(~*ops);
> 
> Really?  That's unlikely to be the right code.
> Maybe just one msg?

Whoah, you're right.  Although the code does actually work.  Just need
one msg though.
 
> > +			void (*func) (void *info) =
> > +				data->func;
> 
> No need to wrap either of these.

OK, fixed.


Thanks,
Richard Kuo


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/