linux-kernel - RE: [PATCH V8 4/4] mm: frontswap: config and doc files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4599ff4c-5273-4605-9a61-d26a9a6484fe@default>
Date:	Tue, 30 Aug 2011 14:51:39 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	Valdis.Kletnieks@...edu
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org, jeremy@...p.org,
	hughd@...gle.com, ngupta@...are.org,
	Konrad Wilk <konrad.wilk@...cle.com>, JBeulich@...ell.com,
	Kurt Hackel <kurt.hackel@...cle.com>, npiggin@...nel.dk,
	akpm@...ux-foundation.org, riel@...hat.com, hannes@...xchg.org,
	matthew@....cx, Chris Mason <chris.mason@...cle.com>,
	sjenning@...ux.vnet.ibm.com, kamezawa.hiroyu@...fujitsu.com,
	jackdachef@...il.com, cyclonusj@...il.com, levinsasha928@...il.com
Subject: RE: [PATCH V8 4/4] mm: frontswap: config and doc files

> From: Valdis.Kletnieks@...edu [mailto:Valdis.Kletnieks@...edu]
> Subject: Re: [PATCH V8 4/4] mm: frontswap: config and doc files
> 
> On Mon, 29 Aug 2011 09:49:49 PDT, Dan Magenheimer said:
> 
> > --- linux/mm/Kconfig	2011-08-08 08:19:26.303686905 -0600
> > +++ frontswap/mm/Kconfig	2011-08-29 09:52:14.308745832 -0600
> > @@ -370,3 +370,20 @@ config CLEANCACHE
> >  	  in a negligible performance hit.
> >
> >  	  If unsure, say Y to enable cleancache
> > +
> > +config FRONTSWAP
> > +	bool "Enable frontswap to cache swap pages if tmem is present"
> > +	depends on SWAP
> > +	default n
> 
> > +
> > +	  If unsure, say Y to enable frontswap.
> 
> Am I the only guy who gets irked when the "default" doesn't match the
> "If unsure" suggestion?  :)  (and yes, I know we have guidelines for
> what the "default" should be...)

Hi Valdis --

Thanks for the review!

Count me as irked.  The default should be "y" because the
overhead is extremely tiny when not enabled at runtime by
a backend (though admittedly non-zero), but I got flamed by
Linus last time I tried that (for cleancache), so I'm not
going to try it for frontswap! :-)  The "if unsure" is the
best I can do for now to encourage distros to enable it.

Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/