linux-kernel - Re: [PATCH 5/5 v4] mfd: omap: usb: Runtime PM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP05o4+cmLWu6e36mkzED1X2f=seS9urXva2dRk5dTLWCBZ9FQ@mail.gmail.com>
Date:	Tue, 30 Aug 2011 11:47:08 +0530
From:	"Munegowda, Keshava" <keshava_mgowda@...com>
To:	Kevin Hilman <khilman@...com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"Balbi, Felipe" <balbi@...com>
Cc:	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, gadiyar@...com, parthab@...ia.ti.com,
	tony@...mide.com, b-cousson@...com, paul@...an.com,
	johnstul@...ibm.com, vishwanath.bs@...com,
	Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCH 5/5 v4] mfd: omap: usb: Runtime PM support

On Tue, Aug 30, 2011 at 2:17 AM, Kevin Hilman <khilman@...com> wrote:
> Kevin Hilman <khilman@...com> writes:
>
>> Keshava Munegowda <keshava_mgowda@...com> writes:
>>
>>> From: Keshava Munegowda <Keshava_mgowda@...com>
>>>
>>> The usbhs core driver does not enable/disable the intefrace and
>>> fucntional clocks; These clocks are handled by hwmod and runtime pm,
>>> hence insted of the clock enable/disable, the runtime pm APIS are
>>> used. however,the port clocks are handled by the usbhs core.
>>>
>>> Signed-off-by: Keshava Munegowda <keshava_mgowda@...com>
>>
>> General comment: all usage of pm_runtime_put_sync() can likely be
>> replaced by the asynchronous versions.  I don't currently see why the
>> synchronous verions are needed here.
>>
>> Other than that, the runtime PM parts of this look OK to me.  After
>> changing to asynchonous puts, feel free to add:
>>
>> Reviewed-by: Kevin Hilman <khilman@...com>
>
> oops, this should've been in response to your v8 version.
>
> Kevin
>
>>
>> Also, after a quick glance, it looks like this version of the series
>> addresses the problems seen by Jassi Brar with the TLL reset[1].  Please
>> confirm.
>>
>> Speaking of which, it's helpful to Cc folks who have had comments on
>> previous versions of your series so they are sure they're previous
>> issues are addressed.   I've Cc'd Jassi Brar.
>>
>> Thanks,
>>
>> Kevin
>>
>> [1] http://marc.info/?l=linux-omap&m=130921260703865&w=2
>

Thanks for review;  yes, its reworks of complete runtime pm of usbhs as
suggested by Jassi Brar.

balbi, sameo
         this patch series available at

the branch kmg-usbhs-pm

of code repository : git://gitorious.org/~kmg/mirrors/kmg-usbhs-pm.git

Regards
Keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/