linux-kernel - Re: [Devel] [PATCH 1/2] ACPICA: Introduce acpi_os_phys_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 31 Aug 2011 11:28:49 +0200
From:	Thomas Renninger <trenn@...e.de>
To:	Lin Ming <ming.m.lin@...el.com>
Cc:	"lenb@...nel.org" <lenb@...nel.org>,
	"eric.piel@...mplin-utc.net" <eric.piel@...mplin-utc.net>,
	"jnelson-suse@...poni.net" <jnelson-suse@...poni.net>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"hpa@...or.com" <hpa@...or.com>,
	"devel@...ica.org" <devel@...ica.org>
Subject: Re: [Devel] [PATCH 1/2] ACPICA: Introduce acpi_os_phys_table_override function

On Wednesday, August 31, 2011 04:43:42 AM Lin Ming wrote:
> On Wed, 2011-08-24 at 17:48 +0800, Thomas Renninger wrote:
...
> You add a new interface.
Yes, is this a bigger problem?

> Can we just extend the existing interface: acpi_os_table_override?
Not sure how to do that without OS/ACPICA API changes.
The virtual address handling is nasty. You have to differ
early mappings (early_ioremap) and later mappings (io/memremap).
Re-mapping later is not possible because the physical address is
lost with the current overriding interface.
The physical address usage is transparent and from what I can
see the only way to provide proper table overriding.

If it's ok to add more paramters to acpi_os_table_override and
either pass the virtual (as before) or the physical address,
this would work:
acpi_os_table_override(struct acpi_table_header *existing_table,
                      struct acpi_table_header **new_table,
                      acpi_physical_address *address, u32 *table_length);

This would be an interface change which looked even worse to me, than 
adding a new function.

   Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/