linux-kernel - Re: [PATCH v4 0/8] Input: elantech: add support for newer hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874o0xdig0.fsf@emc.com.tw>
Date:	Wed, 31 Aug 2011 17:43:59 +0800
From:	JJ Ding <jj_ding@....com.tw>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Seth Forshee <seth.forshee@...onical.com>,
	Aaron Huang <aaron_huang@....com.tw>,
	Tom Lin <tom_lin@....com.tw>,
	Éric Piel <E.A.B.Piel@...elft.nl>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Chase Douglas <chase.douglas@...onical.com>,
	Henrik Rydberg <rydberg@...omail.se>,
	Alessandro Rubini <rubini@...l.unipv.it>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/8] Input: elantech: add support for newer hardware

Hi Dmitry,

What do you think about the series?
Do you think these patches all right for upstream?
Or do you have any other concerns about the chages?
Please let me know and I will fix it.
Thnak you.

jj

On Mon, 29 Aug 2011 16:28:51 +0800, JJ Ding <jj_ding@....com.tw> wrote:
> Hi Lists,
> 
> This is a series of patches to add support for newer generations of ELAN
> touchpad.
> 
> Patches #1~#6 are essentially fixes and cleanups that pave the way for
> patch #7 and patch #8, which really adds code for v3 and v4 hardware.
> 
> Any comments, suggestoins are welcome.
> 
> Note:
> Please review patch #8, which adds support for the latest touchpads from ELAN.
> This is a true multi-touch capable touchpad that can track up to 5 fingers.
> Support is implemented using MT-B protocol. I used synaptics and multitouch X
> driver to test this driver, both worked fine.
> 
> Thank you very much.
> 
> Changes since v1:
> - drop EC workaround patch.
> - add patch #2, make ST and MT have the same range, as Dmitry suggested.
> - add patch #4, remove ETP_EDGE_FUZZ_V2, as Éric suggested.
> - rename all packet checking functions so they are consistent.
> - some code cleanup, and don't report ABS_[XY] when fingers == 0, as Seth suggested.
> - add document for v3 debounce, and now check debounce in elantech_packet_check_v3.
> 
> Changes since v2:
> - fix v3 hardware packet checking (reported by Seth and fix by Dmitry.)
> 
> Changes since v3:
> - fix a tiny style problem (useless space on end-of-line, reported by Seth)
> - v3 hardware can track 2 fingers well, so do not set INPUT_PROP_SEMI_MT on v3
>   (As suggested earlier by Éric.)
> - add patch #8, which adds support for v4 hardware.
> 
> JJ Ding (8):
>   Input: elantech - correct x, y value range for v2 hardware
>   Input: elantech - get rid of ETP_2FT_* in elantech.h
>   Input: elantech - use firmware provided x, y ranges
>   Input: elantech - remove ETP_EDGE_FUZZ_V2
>   Input: elantech - packet checking for v2 hardware
>   Input: elantech - clean up elantech_init
>   Input: elantech - add v3 hardware support
>   Input: elantech - add v4 hardware support
> 
>  Documentation/input/elantech.txt |  295 +++++++++++++++++-
>  drivers/input/mouse/elantech.c   |  614 ++++++++++++++++++++++++++++++++-----
>  drivers/input/mouse/elantech.h   |   56 +++-
>  3 files changed, 849 insertions(+), 116 deletions(-)
> 
> -- 
> 1.7.4.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/