linux-kernel - Re: [patch v2 28/35] Hexagon: Add ioremap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201108311653.37970.arnd@arndb.de>
Date:	Wed, 31 Aug 2011 16:53:37 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Richard Kuo <rkuo@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, linux-hexagon@...r.kernel.org
Subject: Re: [patch v2 28/35] Hexagon: Add ioremap support

On Tuesday 30 August 2011, Richard Kuo wrote:
> Signed-off-by: Richard Kuo <rkuo@...eaurora.org>

Acked-by: Arnd Bergmann <arnd@...db.de>

> +       if (ioremap_page_range(addr, addr+size, phys_addr, prot)) {
> +               vunmap((void *)addr);
> +               return NULL;
> +       }
> +
> +       flush_cache_vmap(addr, addr+size);

I think that ioremap_page_range implies the flush_cache_vmap already,
so there is no reason to do it again.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/