linux-kernel - Re: [PATCH] RDMA/cxgb4: remove accidentally left mutex_unlock(&dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45954.91.79.112.141.1314824511.squirrel@mail.ispras.ru>
Date:	Thu, 1 Sep 2011 01:01:51 +0400 (MSD)
From:	"Alexey Khoroshilov" <khoroshilov@...ras.ru>
To:	"Steve Wise" <swise@...ngridcomputing.com>
Cc:	"Steve Wise" <swise@...lsio.com>,
	"Roland Dreier" <roland@...nel.org>,
	"Sean Hefty" <sean.hefty@...el.com>,
	"Hal Rosenstock" <hal.rosenstock@...il.com>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	ldv-project@...ras.ru
Subject: Re: [PATCH] RDMA/cxgb4: remove accidentally left 
     mutex_unlock(&dev_mutex)

On 01 Sep 2011, 00:46 Steve Wise wrote:
> On 08/31/2011 03:43 PM, Alexey Khoroshilov wrote:
>> The patch "RDMA/cxgb4: EEH errors can hang the driver" removes
>> mutex lock/unlock from c4iw_alloc() except for error path.
>> This patch removes the remained mutex_unlock(&dev_mutex).
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Alexey Khoroshilov<khoroshilov@...ras.ru>
>> ---
>>   drivers/infiniband/hw/cxgb4/device.c |    1 -
>>   1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/cxgb4/device.c
>> b/drivers/infiniband/hw/cxgb4/device.c
>> index 40a13cc..35896ff 100644
>> --- a/drivers/infiniband/hw/cxgb4/device.c
>> +++ b/drivers/infiniband/hw/cxgb4/device.c
>> @@ -414,7 +414,6 @@ static struct c4iw_dev *c4iw_alloc(const struct
>> cxgb4_lld_info *infop)
>>
>>   	ret = c4iw_rdev_open(&devp->rdev);
>>   	if (ret) {
>> -		mutex_unlock(&dev_mutex);
>>   		printk(KERN_ERR MOD "Unable to open CXIO rdev err %d\n", ret);
>>   		ib_dealloc_device(&devp->ibdev);
>>   		return ERR_PTR(ret);
>
> This is actually included in my previously submitted patch:
>
> https://patchwork.kernel.org/patch/1026942/
>
> Steve.

Great.

--
Alexey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/