linux-kernel - Re: [PATCH v3 10/18] Staging: cx25821: Fix long lines in cx25821-audio-upstream.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110831145630.7950a105@inspire>
Date:	Wed, 31 Aug 2011 14:56:30 +0800
From:	"Leonid V. Fedorenchik" <leonidsbox@...il.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Youquan Song <youquan.song@...el.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	Hans Verkuil <hverkuil@...all.nl>,
	Palash Bandyopadhyay <palash.bandyopadhyay@...exant.com>,
	Ruslan Pisarev <ruslan@...sarev.org.ua>,
	devel@...uxdriverproject.org, Joe Perches <joe@...ches.com>,
	Ilya Gorskin <Revent82@...il.com>,
	Ilia Mirkin <imirkin@...m.mit.edu>
Subject: Re: [PATCH v3 10/18] Staging: cx25821: Fix long lines in
 cx25821-audio-upstream.c

On Tue, 30 Aug 2011 17:12:50 +0300
Dan Carpenter <error27@...il.com> wrote:

> On Tue, Aug 30, 2011 at 12:17:05PM +0800, Leonid V. Fedorenchik wrote:
> > @@ -603,7 +599,8 @@ static irqreturn_t cx25821_upstream_irq_audio(int irq, void *dev_id)
> >  	if (!dev)
> >  		return -1;
> >  
> > -	sram_ch = dev->channels[dev->_audio_upstream_channel_select].sram_channels;
> > +	sram_ch = dev->channels[dev->_audio_upstream_channel_select].
> > +			sram_channels;
> 
> $ echo -n "_audio_upstream_channel_select" | wc -c 
> 30
> 
> I think I may have found the problem.  (Don't use variable names that
> are a 30 zillion chars long).
Yes, it's long, but I don't really know how to make it shorter. Is
_audio_upstream_channel OK?

> 
> regards,
> dan carpenter
> 



Leonid V. Fedorenchik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/