linux-kernel - Re: [PATCH] cris: lower the printk level in cris serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpULfmXV96AB5L4K78rLfom+9F=sb6FgGSaOywtOzPt6Pg@mail.gmail.com>
Date:	Thu, 1 Sep 2011 15:16:00 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Mikael Starvik <starvik@...s.com>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	Alan Cox <alan@...ux.intel.com>, linux-cris-kernel@...s.com,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] cris: lower the printk level in cris serial driver

On Thu, Sep 1, 2011 at 2:35 PM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> On Thu, Sep 1, 2011 at 08:14, WANG Cong <xiyou.wangcong@...il.com> wrote:
>> KERN_CRIT is too high, replace those KERN_CRIT with KERN_ERR or KERN_INFO.
>>
>> Cc: Mikael Starvik <starvik@...s.com>
>> Cc: Jesper Nilsson <jesper.nilsson@...s.com>
>> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
>>
>> ---
>> diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
>> index 225123b..77ba4ed 100644
>> --- a/drivers/tty/serial/crisv10.c
>> +++ b/drivers/tty/serial/crisv10.c
>> @@ -1788,7 +1788,7 @@ static unsigned int handle_descr_data(struct e100_serial *info,
>>        struct etrax_recv_buffer *buffer = phys_to_virt(descr->buf) - sizeof *buffer;
>>
>>        if (info->recv_cnt + recvl > 65536) {
>> -               printk(KERN_CRIT
>> +               printk(KERN_INFO
>>                       "%s: Too much pending incoming serial data! Dropping %u bytes.\n", __func__, recvl);
>>                return 0;
>>        }
>
> I think dropped data warrants KERN_WARN.
>

Yeah, agreed! I will update this patch shortly.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/