linux-kernel - RE: [PATCH] cris: lower the printk level in cris serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BEA3FF3CAA35E408EA55C7BE2E61D055C652CFE5D@xmail3.se.axis.com>
Date:	Thu, 1 Sep 2011 10:34:28 +0200
From:	Mikael Starvik <mikael.starvik@...s.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	WANG Cong <xiyou.wangcong@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	Jesper Nilsson <jespern@...s.com>,
	Alan Cox <alan@...ux.intel.com>,
	linux-cris-kernel <linux-cris-kernel@...s.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: RE: [PATCH] cris: lower the printk level in cris serial driver

As a side note crisv10 is old stuff. If you want to change anything keep it simple (like changing log level). Finding someone to verify more correct modifications as Alan proposes may be difficult.

/Mikael

-----Original Message-----
From: Alan Cox [mailto:alan@...rguk.ukuu.org.uk] 
Sent: den 1 september 2011 10:10
To: Geert Uytterhoeven
Cc: WANG Cong; linux-kernel@...r.kernel.org; akpm@...ux-foundation.org; Mikael Starvik; Jesper Nilsson; Alan Cox; linux-cris-kernel; linux-serial@...r.kernel.org
Subject: Re: [PATCH] cris: lower the printk level in cris serial driver

> >        if (info->recv_cnt + recvl > 65536) {
> > -               printk(KERN_CRIT
> > +               printk(KERN_INFO
> >                       "%s: Too much pending incoming serial data! Dropping %u bytes.\n", __func__, recvl);
> >                return 0;
> >        }
> 
> I think dropped data warrants KERN_WARN.

If you have an overflow you want to push the relevant tty flag into the
queue. I'm not sure a printk is that useful - end users of embedded
devices (or even PC desktops) won't see it anyway and if you have serial
console it can actually make things worse

Plus of course it's not rate limited here so its a log wiping vector ...