linux-kernel - RE: [PATCH] ARM: mach-davinci: Select PHYLIB for ARCH_DAVINCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B85A65D85D7EB246BE421B3FB0FBB5930257268D10@dbde02.ent.ti.com>
Date:	Thu, 1 Sep 2011 21:54:41 +0530
From:	"Nori, Sekhar" <nsekhar@...com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"Hilman, Kevin" <khilman@...com>,
	Russell King <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>
Subject: RE: [PATCH] ARM: mach-davinci: Select PHYLIB for ARCH_DAVINCI_DM644x

Hi Axel,

On Sun, Aug 21, 2011 at 10:39:08, Axel Lin wrote:
> We call phy_register_fixup_for_uid in davinci_evm_init, thus we need 
> select PHYLIB to fix below build error: (with "make davinci_all_defconfig")

This shouldn't happen with davinci_all_defconfig as it
selects PHYLIB (this doesn't undermine the need for a fix).

> 
>   LD      .tmp_vmlinux1
> arch/arm/mach-davinci/built-in.o: In function `davinci_phy_fixup':
> pm.c:(.text+0x35b8): undefined reference to `mdiobus_read'
> pm.c:(.text+0x35d4): undefined reference to `mdiobus_write'
> arch/arm/mach-davinci/built-in.o: In function `davinci_evm_init':
> pm.c:(.init.text+0x237c): undefined reference to `phy_register_fixup_for_uid'
> make: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  arch/arm/mach-davinci/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index c0deaca..029ec46b 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -18,6 +18,7 @@ config ARCH_DAVINCI_DM644x
>  	bool "DaVinci 644x based system"
>  	select AINTC
>  	select ARCH_DAVINCI_DMx
> +	select PHYLIB

Selecting PHYLIB for the SoC isn't right because
only the EVM is affected by this issue.

Also, instead of selecting PHYLIB, a better fix
would be to define the fixup function within
#ifdef PHYLIB and have an empty fixup registration
function in case PHYLIB is not defined (which
should happen only when EMAC driver is not configured
in which case a fixup is not required anyway).

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/