linux-kernel - Re: [ PATCH 1/1 ] coredump: use current->group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110901195554.667c5e58@lxorguk.ukuu.org.uk>
Date:	Thu, 1 Sep 2011 19:55:54 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Earl Chew <echew@...acom.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<viro@...iv.linux.org.uk>, <andi@...stfloor.org>, <oleg@...hat.com>
Subject: Re: [ PATCH 1/1 ] coredump: use current->group_leader->comm instead
 of current->comm

On Thu, 1 Sep 2011 10:01:39 -0700
Earl Chew <echew@...acom.com> wrote:

> Change corepattern %e and %E to use current->group_leader->comm instead of current->comm.

Which might break stuff.

> A core dump can be triggered from any task in a group, and substituting current->comm
> means that the name of the core file for a process can vary in surprising ways.

Which some people may well be using

> Using current->group_leader->comm makes the name of the core file more consistent
> for a process when used with %e or %E.

In your view, but there is a better way to do this - add a new case and
letter for the behaviour you want. That way you don't break anyone elses
defaults and expectation and people can set a corepattern dependant upon
the group leader.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/