linux-kernel - Re: [PATCH] PREEMPT_RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Sep 2011 21:14:42 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	John Kacur <jkacur@...hat.com>
cc:	rt-users <linux-rt-users@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PREEMPT_RT_FULL Build error fix

On Fri, 26 Aug 2011, John Kacur wrote:

> Problem:
> make O=/bld/3.0.3-rt11/ kernel/fork.o
> /home/jkacur/jk-2.6/kernel/fork.c:91: error: section of ‘name’ conflicts with previous declaration
> 
> __cacheline_aligned is already part of the definition of DEFINE_RWLOCK
> for -rt
> 
> However it is not always used for the tasklist_lock in non-rt, so it can't
> simply be added to the definition of DEFINE_RWLOCK in non-rt, so I modified
> the definition in fork.c

-ENOPARSE

The real question is whether RWLOCKS should be cacheline aligned in
general or the RT addon is just overkill. Slapping an ifdef around
does not answer that.

Thanks,

	tglx