linux-kernel - Re: [BUG] scsi: hpsa: how to destroy your files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110901130930.5caec2d4@jbarnes-desktop>
Date:	Thu, 1 Sep 2011 13:09:30 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	scameron@...rdog.cce.hp.com
Cc:	Eric Dumazet <eric.dumazet@...il.com>, scameron@...rdog.cce.hp.com,
	Jon Mason <mason@...i.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	stephenmcameron@...il.com, thenzl@...hat.com,
	akpm@...ux-foundation.org, mikem@...rdog.cce.hp.com,
	linux-pci@...r.kernel.org, Roland Dreier <roland@...estorage.com>,
	James Bottomley <James.Bottomley@...senPartnership.com>
Subject: Re: [BUG] scsi: hpsa: how to destroy your files

On Thu, 1 Sep 2011 15:03:49 -0500
scameron@...rdog.cce.hp.com wrote:

> On Thu, Sep 01, 2011 at 12:59:38PM -0700, Jesse Barnes wrote:
> > On Thu, 01 Sep 2011 11:50:38 -0700
> > James Bottomley <James.Bottomley@...senPartnership.com> wrote:
> > 
> > > On Thu, 2011-09-01 at 10:58 -0700, Roland Dreier wrote:
> > > > > OK I found the bad commit,I got lucky... I lost some files but my
> > > > > machine was able to complete the bisection. CC involved people
> > > > 
> > > > > # bad: [b03e7495a862b028294f59fc87286d6d78ee7fa1] PCI: Set PCI-E Max Payload Size on fabric
> > > > 
> > > > Hi Eric,
> > > > 
> > > > I guess it would be useful to see "lspci -vv" output with a "good" kernel
> > > > and with that bad patch applied.  Most likely we should see some difference
> > > > somewhere in the MaxPayload fields in the PCI Express capability of
> > > > some device.
> > > > 
> > > > Either the RAID controller or something else lies, and puts a value
> > > > in the DevCap that it can't actually support, or else the patch is
> > > > buggy and puts something out of range in a DevCtl somewhere.
> > > 
> > > 
> > > While we investigate, I think the problems produced by the patch (data
> > > corruption) are serious enough to warrant reverting it, please Jesse.
> > 
> > Hm I haven't been paying attention to the compromise thread; how should
> > I share these changes?  Is master.kernel.org down indefinitely?  Is
> > there a new server at kernel.org I can use?
> 
> I can't answer that question, but I would like a copy of your revert
> patch(es) to test (as a simple patch --reverse of the original commit on the 3.1-rc4
> tree didn't go in cleanly).

Attached is the series.  Applies on top of my for-linus branch.

-- 
Jesse Barnes, Intel Open Source Technology Center

View attachment "0003-Revert-PCI-Set-PCI-E-Max-Payload-Size-on-fabric.patch" of type "text/x-patch" (12920 bytes)

View attachment "0002-PCI-Revert-PCI-export-pcie_bus_configure_settings-sy.patch" of type "text/x-patch" (930 bytes)

View attachment "0001-PCI-Revert-pci-fix-new-kernel-doc-warning-in-pci.c.patch" of type "text/x-patch" (945 bytes)