linux-kernel - Re: [PATCH 3/3] crc32c: Implement a self-test for CRC32c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110901221854.GA12086@tux1.beaverton.ibm.com>
Date:	Thu, 1 Sep 2011 15:18:54 -0700
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	Bob Pearson <rpearson@...temfabricworks.com>
Cc:	"'Andreas Dilger'" <adilger.kernel@...ger.ca>,
	"'Herbert Xu'" <herbert@...dor.apana.org.au>,
	"'Theodore Tso'" <tytso@....edu>,
	"'David Miller'" <davem@...emloft.net>,
	"'linux-kernel'" <linux-kernel@...r.kernel.org>,
	"'Mingming Cao'" <cmm@...ibm.com>,
	"'linux-crypto'" <linux-crypto@...r.kernel.org>,
	"'linux-fsdevel'" <linux-fsdevel@...r.kernel.org>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/3] crc32c: Implement a self-test for CRC32c

On Thu, Sep 01, 2011 at 12:40:08AM -0500, Bob Pearson wrote:
> Hi Darrick,
> 
> The same code in crc32.c was helpful to measure performance and help code
> tuning as well as indicate correctness. Otherwise the code in crypto may be
> enough to test all the corner cases. If this survives the review I wonder if
> there is a way to combine crc32 and crc32c together somehow. I like yours
> because you can load/unload and not need the memory permanently.

I suspect it would be pretty easy to adapt the Makefile to generate the
relevant .c and .h files; in particular it could be useful to use the crypto
framework for crc32 on the off chance anyone wants to provide hwaccel for that
too.

That said, merging libcrc32c-test vectors with the existing one (sorry, I
didn't realize that existed) shouldn't be too difficult.

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/