linux-kernel - Re: [PATCH 3/3] trace points: power: remove 'cpu_id' from trace_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACVXFVOq2Hn-ZED2LyRQjk72mWJ5N=_LbVw3-vvrK-xUtKZGhQ@mail.gmail.com>
Date:	Fri, 2 Sep 2011 15:38:07 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Jean Pihet <jean.pihet@...oldbits.com>
Cc:	Thomas Renninger <trenn@...e.de>, rostedt@...dmis.org,
	fweisbec@...il.com, mingo@...hat.com, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, Len Brown <lenb@...nel.org>
Subject: Re: [PATCH 3/3] trace points: power: remove 'cpu_id' from trace_cpu_idle

Hi,

On Fri, Sep 2, 2011 at 3:26 PM, Jean Pihet <jean.pihet@...oldbits.com> wrote:
>> It was known that cpu_id is always the current cpu with current
>> implementation when this got introduced.
>> But the perf events API must not change back and forth for userspace
>> compatibility. Therefore the cpu_id was added in case
>> that future implementations want to pass info where the current cpu
>> is not the cpu which is sent to the sleep state.
> Agree. Let's keep the cpu_id field.

OK, let's keep it.

How about removing it in clock_enalbe/clock_disable/power_domain_target
as did in [1/3] and [2/3]?  I don't see any usefulness of 'cpu_id' in the tree
trace points.


thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/