linux-kernel - Re: [PATCH] staging: iio: light: Fix compiler warning in tsl2563.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E60B63C.1030101@cam.ac.uk>
Date:	Fri, 02 Sep 2011 11:55:56 +0100
From:	Jonathan Cameron <jic23@....ac.uk>
To:	"Maxin B. John" <maxin.john@...il.com>
CC:	Dan Carpenter <error27@...il.com>,
	Bryan Freed <bfreed@...omium.org>,
	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-iio@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	devel@...verdev.osuosl.org,
	Amit Kucheria <amit.kucheria@...durent.com>
Subject: Re: [PATCH] staging: iio: light: Fix compiler warning in tsl2563.c

On 09/02/11 10:41, Maxin B. John wrote:
>> Don't overwrite the error code.  For example, the lower layers can
>> return -EAGAIN and that's more useful than just returning -EIO every
>> time.
> Ahh.. Thanks a lot for explaining this.
> 
>> Your fix works, but it's not very clean.  Just add a "*id = ret;"
>> line before the "return 0;" and that's it.  (It doesn't make sense
>> to pass a pointer to "id" and not use it).
> Dan, yes, I agree with you. This fix is much much better than what I 
> had in my mind.
> 
>> Yikes - I wonder why my various compilers don't throw that up.
> I guess, in "iio-blue.git" tree, the 'id = 0' suppresses this warning.
That'd do it. oops.

Ideally keep the white space but doesn't really matter. Either send on
to Greg directly or I'll add it to iio-blue and send on with the next fixes
series - probably this afternoon.
> 
> Signed-off-by: Maxin B. John <maxin.john@...il.com>
Acked-by: Jonathan Cameron <jic23@....ac.uk>

> ---
> diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
> index f25243b..55012ff 100644
> --- a/drivers/staging/iio/light/tsl2563.c
> +++ b/drivers/staging/iio/light/tsl2563.c
> @@ -226,7 +226,7 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id)
>  	ret = i2c_smbus_read_byte_data(client, TSL2563_CMD | TSL2563_REG_ID);
>  	if (ret < 0)
>  		return ret;
> -
> +	*id = ret;
>  	return 0;
>  }
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/