linux-kernel - Re: [PATCH 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1315028055.11839.13.camel@sauron>
Date:	Sat, 03 Sep 2011 07:34:15 +0200
From:	Javier Martinez Canillas <martinez.javier@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Kevin McNeely <kev@...ress.com>,
	Henrik Rydberg <rydberg@...omail.se>,
	Srikar <ext-srikar.1.bhavanarayana@...ia.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Input: cyttsp - Cypress TTSP capacitive
 multi-touch screen support

Hello Dmitry,

On Sun, 2011-08-21 at 21:31 -0700, Dmitry Torokhov wrote:
> Hi Javier,
 
> 
> Still reading through the patches, but have one question:
> 
> > +
> > +	ts->irq = gpio_to_irq(ts->platform_data->irq_gpio);
> > +	if (ts->irq <= 0) {
> > +		dev_dbg(ts->dev, "%s: Error, failed to allocate irq\n",
> > +			__func__);
> > +			goto error_init;
> > +	}
> 
> Why do we need to get gpio/irq from platform data instead of having
> board code set up controllers appropriately and use IRQ either from I2C
> client structure or from SPI?
> 
> Thanks.
> 

Right, next version fix this by extracting the IRQ either from the I2C
or SPI client data structure as you suggest.

Best regards,

Javier Martinez Canillas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/