linux-kernel - Re: [PATCH] vt_ioctl.c: fix compile error with pm_set_vt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110903114641.53170fef@lxorguk.ukuu.org.uk>
Date:	Sat, 3 Sep 2011 11:46:41 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, <gregkh@...e.de>,
	<akpm@...ux-foundation.org>, <art@...ed.ca>, <arnd@...db.de>,
	<jslaby@...e.cz>
Subject: Re: [PATCH] vt_ioctl.c: fix compile error with pm_set_vt_switch()

On Fri, 2 Sep 2011 14:02:42 -0700
H Hartley Sweeten <hartleys@...ionengravers.com> wrote:

> When CONFIG_PM_SLEEP, CONFIG_VT, and CONFIG_VT_CONSOLE are not enabled
> the function pm_set_vt_switch() is defined as an inline in linux/suspend.h. This causes
> a compile error if CONFIG_VT is enabled.
> 
> drivers/tty/vt/vt_ioctl.c:1794: error: redefinition of 'pm_set_vt_switch'
> include/linux/suspend.h:17: error: previous definition of 'pm_set_vt_switch' was here
> 
> Fix this with an #if defined guard around the function in vt_ioctl.c.

Can you put the #if uglies into the buggy suspend.h header instead so the
code proper is kept clean of ifdefs.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/