linux-kernel - Re: [PATCH 4/4] posix-timers: turn it_signal into it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3b9f4c07ac1f801dbbafe54aea43116.squirrel@www.firstfloor.org>
Date:	Sun, 4 Sep 2011 21:07:43 +0200
From:	"Andi Kleen" <andi@...stfloor.org>
To:	"Oleg Nesterov" <oleg@...hat.com>
Cc:	"Thomas Gleixner" <tglx@...utronix.de>,
	"Andi Kleen" <andi@...stfloor.org>,
	"LKML" <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	eric.dumazet@...il.com, "Andi Kleen" <ak@...ux.intel.com>
Subject: Re: [PATCH 4/4] posix-timers: turn it_signal into it_valid flag


> And why do we need to add signal->idr_lock ? It is only used to
> serialize idr_get/idr_remove. Probably we can use ->siglock for that,
> posix timers use this lock anyway.

Ok. In fact idrs have an own lock too, I'll check that out.

>
> Also. I am not sure, but perhaps it make sense to turn
> signal->posix_timers_id into the pointer to "struct idr" and allocate
> idr on demand?

Probably not worth it, it's not big enough.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/