linux-kernel - Re: [PATCH 2/2] mm: Add comment explaining task state setting in bdi_forker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110904030551.GB16361@localhost>
Date:	Sun, 4 Sep 2011 11:05:51 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Jan Kara <jack@...e.cz>
Cc:	Jens Axboe <jaxboe@...ionio.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] mm: Add comment explaining task state setting in
 bdi_forker_thread()

> @@ -401,6 +401,13 @@ static int bdi_forker_thread(void *ptr)
>  		}
>  
>  		spin_lock_bh(&bdi_lock);
> +		/*
> +		 * In the following loop we are going to check whether we have
> +		 * some work to do without any synchronization with tasks
> +		 * waking us up to do work for them. So we have to set task
> +		 * state already here so that we don't miss wakeups coming

s/already/early/ ?

Acked-by: Wu Fengguang <fengguang.wu@...el.com>

> +		 * after we verify some condition.
> +		 */
>  		set_current_state(TASK_INTERRUPTIBLE);
>  
>  		list_for_each_entry(bdi, &bdi_list, bdi_list) {
> -- 
> 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/