linux-kernel - Re: [PATCH 1/2] leds-class: change back LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1315252298.1243.21.camel@ted>
Date:	Mon, 05 Sep 2011 20:51:38 +0100
From:	Richard Purdie <richard.purdie@...uxfoundation.org>
To:	Bryan Wu <bryan.wu@...onical.com>
Cc:	linux@....linux.org.uk, linux-kernel@...r.kernel.org,
	linus.walleij@...aro.org, akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/2] leds-class: change back LEDS_CLASS to tristate
 instead of bool

On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
> LEDS_CLASS is required by leds and trigger drivers, but we can build it
> as module. So change this option back as tristate and treak the help
> message as well.
> 
> Signed-off-by: Bryan Wu <bryan.wu@...onical.com>

Acked-by: Richard Purdie <rchard.purdie@...uxfoundation.org>

> ---
>  drivers/leds/Kconfig |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index b591e72..1c35927 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -17,10 +17,13 @@ menuconfig NEW_LEDS
>  if NEW_LEDS
>  
>  config LEDS_CLASS
> -	bool "LED Class Support"
> +	tristate "LED Class Support"
>  	help
>  	  This option enables the led sysfs class in /sys/class/leds.  You'll
> -	  need this to do anything useful with LEDs.  If unsure, say N.
> +	  need this to do anything useful with LEDs.  If unsure, say M.
> +
> +	  Note: don't disable it as N, because plenty of led and trigger drivers
> +	  are using this option.
>  
>  comment "LED drivers"
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/