linux-kernel - Re: [PATCH 2/2] mm: Add comment explaining task state setting in bdi_forker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110905100141.GA5466@quack.suse.cz>
Date:	Mon, 5 Sep 2011 12:01:41 +0200
From:	Jan Kara <jack@...e.cz>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Jan Kara <jack@...e.cz>, Jens Axboe <jaxboe@...ionio.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] mm: Add comment explaining task state setting in
 bdi_forker_thread()

On Sun 04-09-11 11:05:51, Wu Fengguang wrote:
> > @@ -401,6 +401,13 @@ static int bdi_forker_thread(void *ptr)
> >  		}
> >  
> >  		spin_lock_bh(&bdi_lock);
> > +		/*
> > +		 * In the following loop we are going to check whether we have
> > +		 * some work to do without any synchronization with tasks
> > +		 * waking us up to do work for them. So we have to set task
> > +		 * state already here so that we don't miss wakeups coming
> 
> s/already/early/ ?
  Thanks for review. We'd have to substitute 'already here' with 'early'
for the sentence to make make sense. But frankly I don't see why one would
be better than the other one...

								Honza
> 
> Acked-by: Wu Fengguang <fengguang.wu@...el.com>
> 
> > +		 * after we verify some condition.
> > +		 */
> >  		set_current_state(TASK_INTERRUPTIBLE);
> >  
> >  		list_for_each_entry(bdi, &bdi_list, bdi_list) {
> > -- 
> > 1.7.1
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/