linux-kernel - Re: [PATCH] gpio: rewrite U300 GPIO to use gpiolib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda0-SU5rUYkg7MyNSDpYZPmKYuosfJDh=yHA+Skac1Upg@mail.gmail.com>
Date:	Tue, 6 Sep 2011 11:15:42 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Lee Jones <lee.jones@...aro.org>,
	Ben Hutchings <ben@...adent.org.uk>,
	Debian kernel maintainers <debian-kernel@...ts.debian.org>
Subject: Re: [PATCH] gpio: rewrite U300 GPIO to use gpiolib

On Tue, Sep 6, 2011 at 10:49 AM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:

>> +#include <linux/io.h>
>> +#include <mach/hardware.h>
>> +#include <asm/irq.h>
>> +#include <asm-generic/gpio.h>
>>
>> +/* Map these overrides to gpiolib functions, simply */
>> +#define gpio_get_value  __gpio_get_value
>> +#define gpio_set_value  __gpio_set_value
>> +#define gpio_cansleep   __gpio_cansleep
>> +#define gpio_to_irq     __gpio_to_irq
>>
>> +#endif
>
> This is how mach/gpio.h ends up looking - two things:
>
> 1. is there any reason for asm/irq.h and linux/io.h in there?

No.

> 2. asm/gpio.h already includes asm-generic/gpio.h and defines
>   the dispatchers for the trivial case.

Yep.

> So, I think this is how it should look:
>
> #ifndef __MACH_U300_GPIO_H
> #define __MACH_U300_GPIO_H
> #include <mach/hardware.h>
> #endif
>
> Or even just:
>
> /* empty */

It works fine when left empty, so respinning it like
that.

> if mach/hardware.h include is not required for ARCH_NR_GPIOS.

It'll survive with just the default number of GPIOs.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/