linux-kernel - including <linux/workqueue.h> isn't self contained

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110906182928.GJ28816@pengutronix.de>
Date:	Tue, 6 Sep 2011 20:29:28 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	linux-kernel@...r.kernel.org
Cc:	Baruch Siach <baruch@...s.co.il>,
	Andrew Morton <akpm@...ux-foundation.org>,
	kernel@...gutronix.de, Arnd Bergmann <arnd@...db.de>
Subject: including <linux/workqueue.h> isn't self contained

Hello,

compiling drivers/rtc/rtc-imxdi.c currently results in:

drivers/rtc/rtc-imxdi.c: In function 'di_write_wait':
drivers/rtc/rtc-imxdi.c:168:301: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
drivers/rtc/rtc-imxdi.c:168:301: note: each undeclared identifier is reported only once for each function it appears in
drivers/rtc/rtc-imxdi.c:168:2: error: implicit declaration of function 'signal_pending'
drivers/rtc/rtc-imxdi.c:168:2: error: implicit declaration of function 'schedule_timeout'
drivers/rtc/rtc-imxdi.c: In function 'dryice_norm_irq':
drivers/rtc/rtc-imxdi.c:329:34: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)

This is a regression from 

	4ba8216 (BKL: That's all, folks)

that removes #inclusion of <linux/sched.h> from include/linux/hardirq.h.

Adding

	#include <linux/sched.h>

to the driver fixes it, but I wonder if that is the correct fix because
the driver only uses wait_event_interruptible_timeout (and
wake_up_interruptible) explicitly but none of the three undeclared
symbols.

Any insight welcome.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/