[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4DF117B8.8080408@gmx.net>
Date: Thu, 09 Jun 2011 20:58:00 +0200
From: Witold Szczeponik <Witold.Szczeponik@....net>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
CC: linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: 'flags' in rsparser.c change from 'register disabled resources'
patch
Hi David,
your observation is correct. In fact, the patch can be simplified by
not setting the IORESOURCE_DISABLED flag at all, which is functionally
equivalent to the current state where the compiler removes this value
because it cannot be assigned to a char. A quick compare of the
generated code of the current version (with IORESOURCE_DISABLED
included) and with IORESOURCE_DISABLED not used at all yields pretty
much the same code.
I realized the problem only days after I submitted my patch.
Apparently, a follow-up patch which takes care of the
IORESOURCE_DISABLED flags did not make it into the mainline kernel.
I'll resend it as a response to this post shortly. In addition, in
https://lkml.org/lkml/2011/7/31/50 I submitted a much simpler version of
the patch which better exposes the change it introduces but requires
29df8d8f8702f0f53c1375015f09f04bc8d023c1 to be reverted.
--- Witold
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists